ModuleHasDependencies and VersionPatterns
#150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cies` and its delegates. Also fix the parameter swap in `ModuleHasDependency`.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jevanlingen
reviewed
Aug 12, 2025
src/main/java/org/openrewrite/java/dependencies/search/ModuleHasDependency.java
Show resolved
Hide resolved
jevanlingen
approved these changes
Aug 12, 2025
github-project-automation
bot
moved this from In Progress
to Ready to Review
in OpenRewrite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Fixed the parameter swap in
ModuleHasDependencyto fix configuration of delegates.What's your motivation?
Allow preconditions on module dependencies to work with versions as well.
Anything in particular you'd like reviewers to focus on?
The real fix is to be made in openrewrite/rewrite..
Checklist